avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niels Basjes (JIRA)" <j...@apache.org>
Subject [jira] [Created] (AVRO-1842) Java: Move generated test classes for the avro module
Date Tue, 10 May 2016 09:18:12 GMT
Niels Basjes created AVRO-1842:
----------------------------------

             Summary: Java: Move generated test classes for the avro module
                 Key: AVRO-1842
                 URL: https://issues.apache.org/jira/browse/AVRO-1842
             Project: Avro
          Issue Type: Improvement
          Components: java
            Reporter: Niels Basjes
            Assignee: Niels Basjes


In the java module 'avro' there are classes used in tests that use code generated from schema
definitions. This is generated using the 'compiler' module that depends on 'avro'. 

So what we now have is that in some cases 

- the generated file is committed. ( like lang/java/avro/src/test/java/org/apache/avro/FooBarSpecificRecord.java
and with AVRO-1684 ) and as a consequence this generated code is not update when a change
in the code generator is made and simple changes sometimes cause big differences that are
totally unrelated.
- the tests are put into with the tests of a 'later' module (like the tests in lang/java/ipc/src/test/java/org/apache/avro/specific
)

Proposal: 
- We create a new module 'avro-test' that come after the 'compiler' module. 
- We move the tests in 'avro' that depend on schema generated code to this new package. I
think we should leave as many of the tests as possible in the 'avro' module and only move
the ones that need generated code.
- We move the tests in 'ipc' (and possibly others) that are really tests for 'avro' into 'avro-test'.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message