avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Usachev (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (AVRO-1809) I wish to remove optimization from GenericDatumReader.getResolver
Date Sat, 02 Apr 2016 09:14:25 GMT

     [ https://issues.apache.org/jira/browse/AVRO-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Konstantin Usachev resolved AVRO-1809.
--------------------------------------
    Resolution: Won't Fix

We workarounded our problem by cleaning with reflection shared reader's creator thread. It's
a hack, but I couldn't make up any suitable patch to keep this optimization and resolve our
problem at the same time. So, I'm closing this issue and PR on github. But I'd like you accept
our other patch and PR https://issues.apache.org/jira/browse/AVRO-1808

> I wish to remove optimization from GenericDatumReader.getResolver
> -----------------------------------------------------------------
>
>                 Key: AVRO-1809
>                 URL: https://issues.apache.org/jira/browse/AVRO-1809
>             Project: Avro
>          Issue Type: Wish
>          Components: java
>            Reporter: Konstantin Usachev
>            Priority: Minor
>
> There is an optimization at org.apache.avro.generic.GenericDatumReader.getResolver, when
we cache creator thread and it's first returned value. At first, It looks redundant, because
it saves three calls to Map.get, which is unmeasurable, especially after Schema's hashcode
calculation optimization, made by the same author [~cutting], it's not obvious and adds additional
complexity. Also caching of current thread whould be a source of bugs in case of different
green threads libraries integration (which, actually, occurred during integration with Quasar).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message