avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthieu Monsch (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1793) Python2: Retain stack trace and original exception when failing to parse schema
Date Thu, 04 Feb 2016 04:03:39 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131691#comment-15131691
] 

Matthieu Monsch commented on AVRO-1793:
---------------------------------------

Hi [~jghoman]! Looks good to me, it's a shame that there's no better way of wrapping exceptions
in python 2.

Maybe just two minor comments (not sure if this is the place for them):

+ I think the `str(e)` when you re-reraise is redundant since `%s` formatting will already
do it.
+ Since you fixed the typo in the error message, could we lowercase the capital in "... requires
All symbols ..." as well?

> Python2: Retain stack trace and original exception when failing to parse schema
> -------------------------------------------------------------------------------
>
>                 Key: AVRO-1793
>                 URL: https://issues.apache.org/jira/browse/AVRO-1793
>             Project: Avro
>          Issue Type: Improvement
>          Components: python
>    Affects Versions: 1.8.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: AVRO-1793.patch
>
>
> Currently when a parse call fails the original exception is swallowed and replaced by
a generic SchemaParseException.  We should keep the original stack trace and include the actual
exception message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message