Return-Path: X-Original-To: apmail-avro-dev-archive@www.apache.org Delivered-To: apmail-avro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7901818793 for ; Wed, 20 Jan 2016 09:12:40 +0000 (UTC) Received: (qmail 23062 invoked by uid 500); 20 Jan 2016 09:12:40 -0000 Delivered-To: apmail-avro-dev-archive@avro.apache.org Received: (qmail 23000 invoked by uid 500); 20 Jan 2016 09:12:40 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 22987 invoked by uid 99); 20 Jan 2016 09:12:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 09:12:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C1F3D2C1F55 for ; Wed, 20 Jan 2016 09:12:39 +0000 (UTC) Date: Wed, 20 Jan 2016 09:12:39 +0000 (UTC) From: "Martin Kleppmann (JIRA)" To: dev@avro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AVRO-1785) Ruby: schema_normalization.rb is incompatible with Ruby 1.8.7 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AVRO-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108255#comment-15108255 ] Martin Kleppmann commented on AVRO-1785: ---------------------------------------- +1 on dropping support for Ruby 1.8.7. If there is someone still using 1.8.7, not being able to use the latest version of Avro will be the least of their worries. :) > Ruby: schema_normalization.rb is incompatible with Ruby 1.8.7 > ------------------------------------------------------------- > > Key: AVRO-1785 > URL: https://issues.apache.org/jira/browse/AVRO-1785 > Project: Avro > Issue Type: Bug > Components: ruby > Affects Versions: 1.8.0 > Reporter: Ryan Blue > > I was just checking AVRO-1775 in 1.8.7 and ran into compile errors. The schema_normalization.rb code that was introduced by AVRO-1694 is not compatible with Ruby 1.8.7 because it uses the "new" hash syntax in method definitions. > {code} > blue@work:~/workspace/avro/lang/ruby$ bundle exec rake test > /home/blue/workspace/avro/lang/ruby/Rakefile:19: warning: already initialized constant VERSION > /home/blue/.rvm/rubies/ruby-1.8.7-p374/bin/ruby -I"lib:ext:bin:test" -I"/home/blue/.rvm/gems/ruby-1.8.7-p374/gems/rake-10.4.2/lib" "/home/blue/.rvm/gems/ruby-1.8.7-p374/gems/rake-10.4.2/lib/rake/rake_test_loader.rb" "test/test_help.rb" "test/test_socket_transport.rb" "test/test_fingerprints.rb" "test/test_schema_normalization.rb" "test/test_schema.rb" "test/test_datafile.rb" "test/test_io.rb" "test/test_protocol.rb" > ./lib/avro/schema_normalization.rb:67: warning: else without rescue is useless > ./lib/avro.rb:42:in `require': ./lib/avro/schema_normalization.rb:50: syntax error, unexpected ':', expecting ')' (SyntaxError) > normalize_named_type(schema, fields: fields) > ^ > ./lib/avro/schema_normalization.rb:52: syntax error, unexpected ':', expecting ')' > normalize_named_type(schema, symbols: schema.symbols) > ^ > ./lib/avro/schema_normalization.rb:52: syntax error, unexpected ')', expecting kEND > ./lib/avro/schema_normalization.rb:54: syntax error, unexpected ':', expecting ')' > normalize_named_type(schema, size: schema.size) > ^ > ./lib/avro/schema_normalization.rb:54: syntax error, unexpected ')', expecting kEND > ./lib/avro/schema_normalization.rb:56: odd number list for Hash > { type: type, items: normalize_schema(schema.items) } > ^ > ./lib/avro/schema_normalization.rb:56: syntax error, unexpected ':', expecting '}' > { type: type, items: normalize_schema(schema.items) } > ^ > ./lib/avro/schema_normalization.rb:56: syntax error, unexpected ':', expecting '=' > { type: type, items: normalize_schema(schema.items) } > ^ > ./lib/avro/schema_normalization.rb:56: syntax error, unexpected '}', expecting kEND > ./lib/avro/schema_normalization.rb:58: odd number list for Hash > { type: type, values: normalize_schema(schema.values) } > ^ > ./lib/avro/schema_normalization.rb:58: syntax error, unexpected ':', expecting '}' > { type: type, values: normalize_schema(schema.values) } > ^ > ./lib/avro/schema_normalization.rb:58: syntax error, unexpected ':', expecting '=' > { type: type, values: normalize_schema(schema.values) } > ^ > ./lib/avro/schema_normalization.rb:58: syntax error, unexpected '}', expecting kEND > ./lib/avro/schema_normalization.rb:72: odd number list for Hash > name: field.name, > ^ > ./lib/avro/schema_normalization.rb:72: syntax error, unexpected ':', expecting '}' > name: field.name, > ^ > ./lib/avro/schema_normalization.rb:73: syntax error, unexpected ':', expecting '=' > type: normalize_schema(field.type) > ^ > ./lib/avro/schema_normalization.rb:74: syntax error, unexpected '}', expecting kEND > ./lib/avro/schema_normalization.rb:80: odd number list for Hash > { name: name, type: schema.type_sym.to_s }.merge(attributes) > ^ > ./lib/avro/schema_normalization.rb:80: syntax error, unexpected ':', expecting '}' > { name: name, type: schema.type_sym.to_s }.merge(attributes) > ^ > ./lib/avro/schema_normalization.rb:80: syntax error, unexpected ':', expecting '=' > { name: name, type: schema.type_sym.to_s }.merge(attributes) > ^ > ./lib/avro/schema_normalization.rb:80: syntax error, unexpected '}', expecting kEND > { name: name, type: schema.type_sym.to_s }.merge(attributes) > ^ > from ./lib/avro.rb:42 > from /home/blue/workspace/avro/lang/ruby/test/test_help.rb:22:in `require' > from /home/blue/workspace/avro/lang/ruby/test/test_help.rb:22 > from /home/blue/.rvm/gems/ruby-1.8.7-p374/gems/rake-10.4.2/lib/rake/rake_test_loader.rb:15:in `require' > from /home/blue/.rvm/gems/ruby-1.8.7-p374/gems/rake-10.4.2/lib/rake/rake_test_loader.rb:15 > from /home/blue/.rvm/gems/ruby-1.8.7-p374/gems/rake-10.4.2/lib/rake/rake_test_loader.rb:4:in `select' > from /home/blue/.rvm/gems/ruby-1.8.7-p374/gems/rake-10.4.2/lib/rake/rake_test_loader.rb:4 > rake aborted! > Command failed with status (1): [ruby -I"lib:ext:bin:test" -I"/home/blue/.rvm/gems/ruby-1.8.7-p374/gems/rake-10.4.2/lib" "/home/blue/.rvm/gems/ruby-1.8.7-p374/gems/rake-10.4.2/lib/rake/rake_test_loader.rb" "test/test_help.rb" "test/test_socket_transport.rb" "test/test_fingerprints.rb" "test/test_schema_normalization.rb" "test/test_schema.rb" "test/test_datafile.rb" "test/test_io.rb" "test/test_protocol.rb" ] > /home/blue/.rvm/gems/ruby-1.8.7-p374/gems/echoe-4.6.6/lib/echoe.rb:749:in `define_tasks' > /home/blue/.rvm/gems/ruby-1.8.7-p374/bin/ruby_executable_hooks:15 > Tasks: TOP => test_inner > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)