Return-Path: X-Original-To: apmail-avro-dev-archive@www.apache.org Delivered-To: apmail-avro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 71755182A8 for ; Mon, 18 Jan 2016 17:37:40 +0000 (UTC) Received: (qmail 94914 invoked by uid 500); 18 Jan 2016 17:37:40 -0000 Delivered-To: apmail-avro-dev-archive@avro.apache.org Received: (qmail 94825 invoked by uid 500); 18 Jan 2016 17:37:40 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 94645 invoked by uid 99); 18 Jan 2016 17:37:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 17:37:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F24962C1F6D for ; Mon, 18 Jan 2016 17:37:39 +0000 (UTC) Date: Mon, 18 Jan 2016 17:37:39 +0000 (UTC) From: "Martin Kleppmann (JIRA)" To: dev@avro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AVRO-1663) C Library does not handle enum's namespace MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AVRO-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105562#comment-15105562 ] Martin Kleppmann commented on AVRO-1663: ---------------------------------------- Could someone please clarify how updates to {{lang/c/version.sh}} should be handled? Should I update the version number while committing the patch, or does that happen as part of the release process? Judging from the commit history of that file, it seems like it's been done as part of patch commits in the past, but there also seem to have been commits that changed the API without updating that file, so I'm a bit confused. > C Library does not handle enum's namespace > ------------------------------------------ > > Key: AVRO-1663 > URL: https://issues.apache.org/jira/browse/AVRO-1663 > Project: Avro > Issue Type: Bug > Components: c > Affects Versions: 1.7.7 > Reporter: Thomas Sanchez > Assignee: Martin Kleppmann > Attachments: AVRO-1663-2.patch, AVRO-1663-3.patch, AVRO-1663-4.patch, AVRO-1663.patch > > > {code}{ > "type": "record", > "name": "EventName", > "namespace": "com.company.avro.schemas", > "fields": [ > {"name": "eventname_model", > "type": { > "type": "enum", > "namespace": "com.company.models", > "name": "EventName", > "symbols": ["XXXX"] > } > } > ] > } > {code} > Such a schema is perfectly valid but the C library does no handle it because it does not parse the namespace field. -- This message was sent by Atlassian JIRA (v6.3.4#6332)