Return-Path: X-Original-To: apmail-avro-dev-archive@www.apache.org Delivered-To: apmail-avro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB103188CC for ; Fri, 4 Dec 2015 00:43:11 +0000 (UTC) Received: (qmail 86039 invoked by uid 500); 4 Dec 2015 00:43:11 -0000 Delivered-To: apmail-avro-dev-archive@avro.apache.org Received: (qmail 85920 invoked by uid 500); 4 Dec 2015 00:43:11 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 85808 invoked by uid 99); 4 Dec 2015 00:43:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2015 00:43:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1FBC92C1F71 for ; Fri, 4 Dec 2015 00:43:11 +0000 (UTC) Date: Fri, 4 Dec 2015 00:43:11 +0000 (UTC) From: "Matthieu Monsch (JIRA)" To: dev@avro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AVRO-1767) Simplify union wrapping logic. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AVRO-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthieu Monsch updated AVRO-1767: ---------------------------------- Attachment: AVRO-1767.patch > Simplify union wrapping logic. > ------------------------------ > > Key: AVRO-1767 > URL: https://issues.apache.org/jira/browse/AVRO-1767 > Project: Avro > Issue Type: Improvement > Components: javascript > Reporter: Matthieu Monsch > Attachments: AVRO-1767.patch > > > Previously, union wrapping during `type.clone` calls would be done in place > of normal copy. Now it is done as a backup if a normal copy fails. This is > more consistent with the documentation, and makes it much simpler to wrap > nested unions. > See here for more information and examples: https://github.com/mtth/avsc/issues/16 > Other changes: > + Add an optional argument to `type.getName` to expose built-in type names > (useful to implement an "optional" logical type for example). > + Document (and rename) `assertLogicalTypes` parsing option. > + Tweak logical type validity check, enabling error hooks to work even when a > logical type is valid for a subset of its underlying type's values (e.g. when > defining an "even integer" type). Previously the path would have been correct > but the type would have been that of the underlying one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)