avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Kleppmann (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AVRO-1725) Enum schema exhibits same restriction to enum symbols as to names
Date Wed, 30 Dec 2015 18:14:49 GMT

     [ https://issues.apache.org/jira/browse/AVRO-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Martin Kleppmann updated AVRO-1725:
    Attachment: AVRO-1725.patch

Agree with [~cutting]. I've attached a documentation patch, adding the restriction on enum
symbols to the spec.

> Enum schema exhibits same restriction to enum symbols as to names
> -----------------------------------------------------------------
>                 Key: AVRO-1725
>                 URL: https://issues.apache.org/jira/browse/AVRO-1725
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Nikita Makeev
>         Attachments: AVRO-1725.patch
> EnumSchema class in org.apache.avro.Schema has the following code:
> for (String symbol : symbols)
>         if (ordinals.put(validateName(symbol), i++) != null)
> which validates enum symbols using validateName() which makes impossible to use symbols
that are not conforming to standard for real names. 
> That prohibits using of symbols like "" (empty string) or anything starting with number
which does not seem to be intended.
> I guess this place requires either some another type of validation or no validation at
all. Can provide a patch for both cases.

This message was sent by Atlassian JIRA

View raw message