avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nikita Makeev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1725) Enum schema exhibits same restriction to enum symbols as to names
Date Tue, 15 Dec 2015 09:33:46 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057707#comment-15057707
] 

Nikita Makeev commented on AVRO-1725:
-------------------------------------

[~rdblue], I guess so. With current validation I can't use, for instance, following enum:

{ "type": "enum",
  "name": "Source",
  "symbols" : [ "", "9gag", "2chan", "4chan" ]
}


> Enum schema exhibits same restriction to enum symbols as to names
> -----------------------------------------------------------------
>
>                 Key: AVRO-1725
>                 URL: https://issues.apache.org/jira/browse/AVRO-1725
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Nikita Makeev
>
> EnumSchema class in org.apache.avro.Schema has the following code:
> for (String symbol : symbols)
>         if (ordinals.put(validateName(symbol), i++) != null)
> which validates enum symbols using validateName() which makes impossible to use symbols
that are not conforming to standard for real names. 
> That prohibits using of symbols like "" (empty string) or anything starting with number
which does not seem to be intended.
> I guess this place requires either some another type of validation or no validation at
all. Can provide a patch for both cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message