avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1560) SNAPPY_INCLUDE_DIR not accounted in CMakeLists.txt
Date Wed, 30 Dec 2015 15:52:49 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075129#comment-15075129
] 

ASF subversion and git services commented on AVRO-1560:
-------------------------------------------------------

Commit 1722365 from [~martinkl] in branch 'avro/branches/branch-1.8'
[ https://svn.apache.org/r1722365 ]

AVRO-1560: C: Fix build for custom libsnappy location. Contributed by Ujjwal.

> SNAPPY_INCLUDE_DIR not accounted in CMakeLists.txt
> --------------------------------------------------
>
>                 Key: AVRO-1560
>                 URL: https://issues.apache.org/jira/browse/AVRO-1560
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.7.7
>            Reporter: Ujjwal
>            Priority: Minor
>              Labels: build
>         Attachments: AVRO-1560.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The current CMakeLists.txt does not account for Snappy include folders causing the compilation
to fail when a custom snappy location is provided using -DSNAPPY_ROOT_DIR
> e.g .
> {code:xml}
> cmake avro-c-1.7.7 -DSNAPPY_ROOT_DIR=${SNAPPY_INSTALL_DIR}
> {code}
> In https://github.com/apache/avro/blob/release-1.7.7/lang/c/CMakeLists.txt#L143 we should
include 
> {code:xml}
> include_directories(${SNAPPY_INCLUDE_DIR})
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message