Return-Path: X-Original-To: apmail-avro-dev-archive@www.apache.org Delivered-To: apmail-avro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5DFF218803 for ; Tue, 7 Jul 2015 17:56:10 +0000 (UTC) Received: (qmail 25773 invoked by uid 500); 7 Jul 2015 17:56:05 -0000 Delivered-To: apmail-avro-dev-archive@avro.apache.org Received: (qmail 25708 invoked by uid 500); 7 Jul 2015 17:56:05 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 25693 invoked by uid 99); 7 Jul 2015 17:56:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jul 2015 17:56:05 +0000 Date: Tue, 7 Jul 2015 17:56:05 +0000 (UTC) From: "Ryan Blue (JIRA)" To: dev@avro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AVRO-1692) Allow more than one logical type for a Java class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AVRO-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617073#comment-14617073 ] Ryan Blue commented on AVRO-1692: --------------------------------- I can add tests as part of AVRO-1672, or I can add the circular reference test that I posted to the mailing list for Sachin. Either one demonstrates the problem. > Allow more than one logical type for a Java class > ------------------------------------------------- > > Key: AVRO-1692 > URL: https://issues.apache.org/jira/browse/AVRO-1692 > Project: Avro > Issue Type: Task > Components: java > Reporter: Ryan Blue > Assignee: Ryan Blue > Fix For: 1.8.0 > > Attachments: AVRO-1692.1.patch > > > The initial logical types implementation assumed that there would only be one logical type per concrete class and kept a lookup table from class to conversion. There are cases where this assumption doesn't work. For example, both time-millis and time-micros can be represented by the same class, LocalTime, and the write path should use the correct logical type's conversion depending on the schema. -- This message was sent by Atlassian JIRA (v6.3.4#6332)