Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Fri, 3 Jul 2015 13:04:04 +0000 (UTC)
From: "Tom White (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: <JIRA.12836368.1433828346000.93919.1435928644916@Atlassian.JIRA>
In-Reply-To: <JIRA.12836368.1433828346000@Atlassian.JIRA>
References: <JIRA.12836368.1433828346000@Atlassian.JIRA>
 <JIRA.12836368.1433828346560@arcas>
Subject: [jira] [Commented] (AVRO-1679)
 DataFileReader.SeekableInputStream.skip seeking rather than skipping
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AVRO-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613176#comment-14613176 ] 

Tom White commented on AVRO-1679:
---------------------------------

Thanks for the patch Erik. This needs a unit test that fails when the fix is not present, and passes with the fix applied.

> DataFileReader.SeekableInputStream.skip seeking rather than skipping
> --------------------------------------------------------------------
>
>                 Key: AVRO-1679
>                 URL: https://issues.apache.org/jira/browse/AVRO-1679
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Erik Krogen
>            Priority: Minor
>         Attachments: AVRO-1679.patch
>
>
> Within DataFileReader.SeekableInputStream, the skip method acts as a seek rather than a skip (seeking to the offset which is passed in rather than skipping ahead by that offset). It passes the value through to the underlying SeekableInput's seek method without first adding the current position within the input. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)