avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AVRO-1698) cant serialize json with characters >127 when compiling with signed char
Date Thu, 09 Jul 2015 18:36:04 GMT

     [ https://issues.apache.org/jira/browse/AVRO-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sean Busbey updated AVRO-1698:
------------------------------
    Attachment: AVRO-1698.1.patch

attaching patch from [github pr #38|https://github.com/apache/avro/pull/38]

> cant serialize json with characters >127 when compiling with signed char
> ------------------------------------------------------------------------
>
>                 Key: AVRO-1698
>                 URL: https://issues.apache.org/jira/browse/AVRO-1698
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.7
>         Environment: windows, linux w signed char
>            Reporter: svante karlsson
>         Attachments: AVRO-1698.1.patch
>
>
> iscntrl assumes 0-255 but signed char gets expanded to bad things
> pullreq #38  on github solves the issue.
> change line 196 lang/c++/impl/json/JsonIO.hh
> from 
>   if (! iscntrl(*p)) {
> to
>  if (! iscntrl((uint8_t) *p)) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message