avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1679) DataFileReader.SeekableInputStream.skip seeking rather than skipping
Date Fri, 03 Jul 2015 13:04:04 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613176#comment-14613176
] 

Tom White commented on AVRO-1679:
---------------------------------

Thanks for the patch Erik. This needs a unit test that fails when the fix is not present,
and passes with the fix applied.

> DataFileReader.SeekableInputStream.skip seeking rather than skipping
> --------------------------------------------------------------------
>
>                 Key: AVRO-1679
>                 URL: https://issues.apache.org/jira/browse/AVRO-1679
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Erik Krogen
>            Priority: Minor
>         Attachments: AVRO-1679.patch
>
>
> Within DataFileReader.SeekableInputStream, the skip method acts as a seek rather than
a skip (seeking to the offset which is passed in rather than skipping ahead by that offset).
It passes the value through to the underlying SeekableInput's seek method without first adding
the current position within the input. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message