avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sachingsachin <...@git.apache.org>
Subject [GitHub] avro pull request: AVRO-1562: Support classes extending Maps/Colle...
Date Wed, 11 Mar 2015 21:16:42 GMT
GitHub user sachingsachin opened a pull request:

    https://github.com/apache/avro/pull/25

    AVRO-1562: Support classes extending Maps/Collections in Avro

    For classes extending collections and maps, "_avro_implicit_collection_" and "_avro_implicit_map_"
fields are added in the Avro representation while the class itself continues to hold other
fields normally like a record.
    The implicit field-names are currently hardcoded as above.
    We will need to have an API in ReflectData for making this configurable.
    
    We may also need some name-mangling to have different names for classes extending different
parameterized collections/maps.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sachingsachin/avro AVRO-1562

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit f13568f3064f56064edddeb2d122e11888e23831
Author: Sachin Goyal <sgoyal@walmart.com>
Date:   2015-03-11T21:12:18Z

    AVRO-1562: Support classes extending Maps/Collections in Avro
    
    For classes extending collections and maps, "_avro_implicit_collection_" and "_avro_implicit_map_"
fields are added in the Avro representation while the class itself continues to hold other
fields normally like a record.
    The implicit field-names are currently hardcoded as above.
    We will need to have an API in ReflectData for making this configurable.
    
    We may also need some name-mangling to have different names for classes extending different
parameterized collections/maps.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message