avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1608) Deprecate mutator methods on Schema
Date Wed, 26 Nov 2014 19:51:12 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226728#comment-14226728
] 

Doug Cutting commented on AVRO-1608:
------------------------------------

I agree that we should avoid making Name public if possible.

I'd also like to see all calls to these deprecated methods removed when they're deprecated,
to demonstrate that the alternatives are practical.  The patch to remove them should then
only need to remove them, not also make other changes.  We should test that (as we should
with other deprecations).

> Deprecate mutator methods on Schema
> -----------------------------------
>
>                 Key: AVRO-1608
>                 URL: https://issues.apache.org/jira/browse/AVRO-1608
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 1.7.8
>
>         Attachments: AVRO-1608.patch
>
>
> This is a follow on to AVRO-261. It would be good to deprecate JsonProperties#addProp,
Schema#addAlias, and Schema.Field#addAlias, and remove them in 1.8.0. Instead users should
use SchemaBuilder, or we could also provide overloaded variants of the factory methods on
Schema to specify properties and aliases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message