avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Spadoni <mspad...@inome.com>
Subject RE: [jira] [Commented] (AVRO-1591) Java - handle hashCode / equals / toString in SpecificRequestor
Date Fri, 03 Oct 2014 22:00:57 GMT
Updated patch is up.  I rewrote the toString handler and the other two were straight passthroughs.
 Unit tests are included.
________________________________________
From: Doug Cutting (JIRA) [jira@apache.org]
Sent: Friday, October 03, 2014 2:47 PM
To: dev@avro.apache.org
Subject: [jira] [Commented] (AVRO-1591) Java - handle hashCode / equals / toString in SpecificRequestor

    [ https://issues.apache.org/jira/browse/AVRO-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158565#comment-14158565
]

Doug Cutting commented on AVRO-1591:
------------------------------------

The "Oracle source" comment still makes me nervous.  Where did you copy that from?  What license
was it under?

> Java - handle hashCode / equals / toString in SpecificRequestor
> ---------------------------------------------------------------
>
>                 Key: AVRO-1591
>                 URL: https://issues.apache.org/jira/browse/AVRO-1591
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Mark Spadoni
>         Attachments: AVRO-1591.patch
>
>
> SpecificRequestor does not handle hashCode / equals / toString in its invoke method.
 This problem cropped up when using commons-pool2's GenericKeyedObjectPool.create(), which
attempts to put pool object wrappers into a map, keying off the original object:
> objectDeque.getAllObjects().put(p.getObject(), p);
> The put calls hashCode() which is not handled, resulting in an AvroRemoteException.
> See proposed patch for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)




Mime
View raw message