avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keegan Witt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1551) SpecificCompilerTool should have outputEncoding option
Date Fri, 05 Sep 2014 16:47:29 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123145#comment-14123145
] 

Keegan Witt commented on AVRO-1551:
-----------------------------------

Sorry for not replying sooner.  We can do that, but the new java files will have a particular
encoding.  This is problematic at the moment since org.apache.avro.tool.TestSpecificCompilerTool#readFile
is using FileReader, which uses the default encoding.  If we use the same output files to
test this, we'll need to make all tests use the same encoding (in which case a separate test
case is unnecessary).  Should I do that?  Or go back to the separate output file idea?

> SpecificCompilerTool should have outputEncoding option
> ------------------------------------------------------
>
>                 Key: AVRO-1551
>                 URL: https://issues.apache.org/jira/browse/AVRO-1551
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Keegan Witt
>             Fix For: 1.7.8
>
>         Attachments: AVRO-1551.patch, AVRO-1551_2.patch
>
>
> The same way AVRO-1471 allows you to set the output encoding from Maven, the SpecificCompilerTool
commandline tool should allow you to do the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message