avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Blue (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-739) Add Date/Time data types
Date Thu, 07 Aug 2014 18:24:15 GMT

    [ https://issues.apache.org/jira/browse/AVRO-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089565#comment-14089565
] 

Ryan Blue commented on AVRO-739:
--------------------------------

Dmitry, thanks for doing this. It looks really good to me with just a couple of minor things:
* If the timezone Z is required for timestamp-millis and the milliseconds are optional, then
the naive sort order no longer works. My vote is to require milliseconds in the string representations
for both time-millis and timestamp-millis to solve the problem.
{code}
>> '10.123Z' < '10Z'
=> true
{code}
* The interval type needs to specify the endianness of its components. Parquet uses little-endian,
so I'd say we should specify that here also.
* I'd rather not include representations that have a time zone because the logic is always
tricky and changes. I think best practice is to convert to UTC and I'd like for people to
do that rather than using an expensive representation to get around best practice.

> Add Date/Time data types
> ------------------------
>
>                 Key: AVRO-739
>                 URL: https://issues.apache.org/jira/browse/AVRO-739
>             Project: Avro
>          Issue Type: New Feature
>          Components: spec
>            Reporter: Jeff Hammerbacher
>             Fix For: 1.7.8
>
>         Attachments: AVRO-739-datetime-spec.xml.patch, AVRO-739.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message