avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Willem van Bergen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1536) Remove monkeypatching of Enumerable
Date Wed, 02 Jul 2014 15:48:26 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050222#comment-14050222
] 

Willem van Bergen commented on AVRO-1536:
-----------------------------------------

Looks good!

> Remove monkeypatching of Enumerable
> -----------------------------------
>
>                 Key: AVRO-1536
>                 URL: https://issues.apache.org/jira/browse/AVRO-1536
>             Project: Avro
>          Issue Type: Improvement
>          Components: ruby
>    Affects Versions: 1.7.6
>            Reporter: Martin Kleppmann
>            Assignee: Martin Kleppmann
>             Fix For: 1.7.7
>
>         Attachments: AVRO-1536.patch
>
>
> The Avro Ruby gem adds a method {{collect_hash}} to the core module {{Enumerable}}. It's
bad form for a library to extend core modules like this, and it's also unnecessary (stdlib
methods can do the job perfectly well).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message