avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Blue (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1402) Support for DECIMAL type
Date Mon, 14 Apr 2014 20:28:18 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968798#comment-13968798
] 

Ryan Blue commented on AVRO-1402:
---------------------------------

[~xuefuz], what I'm trying to say is that it's an error if the underlying type cannot fit
the precision the user expects. And because that underlying type can't be changed, we should
avoid mistakes by making the precision required so we can check as soon as possible and before
data is written.

To your point about changing the value to fit the storage, that may be fine for Hive but I
think a data storage format shouldn't change the data. Storing a decimal(5,2) in a decimal(4,1)
discards data and requires a rounding policy, so it should be treated as an error if Avro
is handling the encoding. If Hive is encoding the decimal, then the decision is left up to
Hive.

> Support for DECIMAL type
> ------------------------
>
>                 Key: AVRO-1402
>                 URL: https://issues.apache.org/jira/browse/AVRO-1402
>             Project: Avro
>          Issue Type: New Feature
>    Affects Versions: 1.7.5
>            Reporter: Mariano Dominguez
>            Assignee: Tom White
>            Priority: Minor
>              Labels: Hive
>             Fix For: 1.7.7
>
>         Attachments: AVRO-1402-logical-type-spec-2.patch, AVRO-1402-logical-type-spec-3.patch,
AVRO-1402-logical-type-spec-4.patch, AVRO-1402-logical-type-spec.patch, AVRO-1402.patch, AVRO-1402.patch,
AVRO-1402.patch, AVRO-1402.patch, UnixEpochRecordMapping.patch
>
>
> Currently, Avro does not seem to support a DECIMAL type or equivalent.
> http://avro.apache.org/docs/1.7.5/spec.html#schema_primitive
> Adding DECIMAL support would be particularly interesting when converting types from Avro
to Hive, since DECIMAL is already a supported data type in Hive (0.11.0).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message