avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1471) avro-maven-plugin schema generation should use project.build.sourceEncoding for generated files
Date Thu, 13 Mar 2014 18:09:44 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933669#comment-13933669
] 

Doug Cutting commented on AVRO-1471:
------------------------------------

The patch looks good.  Can you please supply a test case?  It should be straightforward to
add one to TestSpecificCompiler.java.  Thanks!

> avro-maven-plugin schema generation should use project.build.sourceEncoding for generated
files
> -----------------------------------------------------------------------------------------------
>
>                 Key: AVRO-1471
>                 URL: https://issues.apache.org/jira/browse/AVRO-1471
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.7
>         Environment: MacOS 10.9
>            Reporter: Eugene Mustaphin
>            Priority: Minor
>             Fix For: 1.7.7
>
>         Attachments: AVRO-1471.patch
>
>
> avro-maven-plugin generates java sources using system default encoding which is not good
if maven project sources' encoding is different (which is often true on OS with non-UTF-8
system encoding like OSX and Windows) as generated files encoding differs from the rest of
the project sources.
> It would be great if avro-maven-plugin used the project.build.sourceEncoding property
for generated sources.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message