avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1442) Case "FIXED" not handled in ResolvingGrammarGenerator
Date Thu, 13 Mar 2014 20:47:42 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934029#comment-13934029
] 

Doug Cutting commented on AVRO-1442:
------------------------------------

Jim, can you please provide a patch file for the proposed change?  Also, a unit test would
be great.  Thanks!

> Case "FIXED" not handled in ResolvingGrammarGenerator
> -----------------------------------------------------
>
>                 Key: AVRO-1442
>                 URL: https://issues.apache.org/jira/browse/AVRO-1442
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.5
>            Reporter: Jim Pivarski
>              Labels: exceptions
>
> Symptom: Attempts to match reader = FIXED against writer != FIXED results in a RuntimeException
("Unexpected schema type: FIXED"), rather than an appropriate Symbol.ErrorAction.
> Reason: In the ResolvingGrammarGenerator.generate method, there are two switch statements,
one for writerType == readerType and the other for writerType != readerType.  In the latter,
"case FIXED:" is missing.
> This is true in the GitHub version (HEAD?) as well: https://github.com/apache/avro/blob/branch-1.3/lang/java/src/java/org/apache/avro/io/parsing/ResolvingGrammarGenerator.java#L155



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message