Return-Path: X-Original-To: apmail-avro-dev-archive@www.apache.org Delivered-To: apmail-avro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1320A10E92 for ; Fri, 31 Jan 2014 17:55:45 +0000 (UTC) Received: (qmail 42110 invoked by uid 500); 31 Jan 2014 17:55:44 -0000 Delivered-To: apmail-avro-dev-archive@avro.apache.org Received: (qmail 41956 invoked by uid 500); 31 Jan 2014 17:55:43 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Delivered-To: moderator for dev@avro.apache.org Received: (qmail 5106 invoked by uid 99); 31 Jan 2014 16:48:44 -0000 Content-Type: multipart/alternative; boundary="===============7894192494516700115==" MIME-Version: 1.0 Subject: Review Request 17549: AVRO-1443. Java builder and record API improvements. From: "Christophe Taton" To: "Christophe Taton" , "Avro" Date: Fri, 31 Jan 2014 16:48:42 -0000 Message-ID: <20140131164842.21455.23044@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Christophe Taton" X-ReviewGroup: Avro X-ReviewRequest-URL: https://reviews.apache.org/r/17549/ X-Sender: "Christophe Taton" Reply-To: "Christophe Taton" X-ReviewRequest-Repository: avro --===============7894192494516700115== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17549/ ----------------------------------------------------------- Review request for Avro. Repository: avro Description ------- AVRO-1443. Java builder and record API improvements. - All builders (generic and specific) extend generic records - Specific record builders do NOT extend GenericRecordBuilder, but implement the generic record builders interface. - Introduce interfaces for indexed/generic record builders. - Introduce interfaces for immutable indexed/generic records. - Update velocity template to add the new methods required for builders. - Deleted FooBarSpecificRecord (apparently unused, no schema definition available). Diffs ----- http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/data/ErrorBuilder.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/data/RecordBuilder.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/data/RecordBuilderBase.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericContainer.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericRecord.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericRecordBuilder.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/IndexedRecord.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificErrorBuilderBase.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecord.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecordBase.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecordBuilderBase.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/test/java/org/apache/avro/compiler/TestSpecificCompiler.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/test/compiler/output-string/avro/examples/baseball/Player.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/test/compiler/output/Player.java 1560101 http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/test/java/org/apache/avro/tool/TestSpecificCompilerTool.java 1560101 Diff: https://reviews.apache.org/r/17549/diff/ Testing ------- mvn clean test Thanks, Christophe Taton --===============7894192494516700115==--