avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christophe Taton" <christophe.ta...@gmail.com>
Subject Review Request 17549: AVRO-1443. Java builder and record API improvements.
Date Fri, 31 Jan 2014 16:48:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17549/
-----------------------------------------------------------

Review request for Avro.


Repository: avro


Description
-------

AVRO-1443. Java builder and record API improvements.

 - All builders (generic and specific) extend generic records
 - Specific record builders do NOT extend GenericRecordBuilder,
   but implement the generic record builders interface.
 - Introduce interfaces for indexed/generic record builders.
 - Introduce interfaces for immutable indexed/generic records.
 - Update velocity template to add the new methods required for builders.
 - Deleted FooBarSpecificRecord (apparently unused, no schema definition available).


Diffs
-----

  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/data/ErrorBuilder.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/data/RecordBuilder.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/data/RecordBuilderBase.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericContainer.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericRecord.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericRecordBuilder.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/IndexedRecord.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificErrorBuilderBase.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecord.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecordBase.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificRecordBuilderBase.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/test/java/org/apache/avro/compiler/TestSpecificCompiler.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/test/compiler/output-string/avro/examples/baseball/Player.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/test/compiler/output/Player.java
1560101 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/test/java/org/apache/avro/tool/TestSpecificCompilerTool.java
1560101 

Diff: https://reviews.apache.org/r/17549/diff/


Testing
-------

mvn clean test


Thanks,

Christophe Taton


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message