Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Wed, 18 Dec 2013 13:28:07 +0000 (UTC)
From: "Douglas Creager (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: <JIRA.12659678.1374704563836.57534.1387373287785@arcas>
In-Reply-To: <JIRA.12659678.1374704563836@arcas>
References: <JIRA.12659678.1374704563836@arcas>
Subject: [jira] [Resolved] (AVRO-1358) internal version of jansson exports
 the jansson symbols which collide with json-c and jansson libraries
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/AVRO-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Douglas Creager resolved AVRO-1358.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.7.6

Merged this into SVN.  I hid the {{hashtable}} functions, as requested, as well as a handful of other internal Jansson functions.  Basically, I id anything that doesn't start with {{avro_}} or {{AVRO_}}.

> internal version of jansson exports the jansson symbols which collide with json-c and jansson libraries
> -------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-1358
>                 URL: https://issues.apache.org/jira/browse/AVRO-1358
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.7.4
>         Environment: linux
>            Reporter: External Builds
>             Fix For: 1.7.6
>
>         Attachments: 0001-Hide-Jansson-symbols-in-Avro-library.patch
>
>
> The 1.7.x version of AVRO includes an "internal" copy of jansson library, but it also exports all of the jansson symbols which will collide with other libraries. The symbol 'json_object_get' will collide with the json-c library and all of the 'json_*' symbols collide with the external jansson library.
> If you don't want to have an external dependency on 'jansson' then it seems that the symbols will need to have a hidden visibility or some other mechanism to keep them from being exported with the AVRO library.
> As a temporary solution we have wrapped the internal jansson functions with this so they are hidden:
> #pragma GCC visibility push(hidden)
> json_function()
> #pragma GCC visibility pop
> Many other solutions exist. I don't see that having an external dependency is such a drawback, as many other open source packages have dependencies on other open source packages, but any solution would be appreciated.
> Thanks!


--
This message was sent by Atlassian JIRA
(v6.1.4#6159)