avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Kleppmann (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1063) Ruby client should use multi_json rather than being locked down to yajl
Date Fri, 20 Dec 2013 01:02:32 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853545#comment-13853545
] 

Martin Kleppmann commented on AVRO-1063:
----------------------------------------

I think it's a good idea to commit the Gemfile you attached, and to have the buildbot run
'bundle install && bundle exec rake test'. Bundler is now considered the standard
way of managing gems in the Ruby community, and this is the right way to use it.

Running 'bundle install' will generate a Gemfile.lock in the same directory, and subsequent
runs of 'bundle install' will continue to use the versions of dependencies that were downloaded
when the Gemfile.lock was created, unless you explicitly upgrade gems. If you want to always
run against the latest versions of dependencies, you can delete the Gemfile.lock before/after
each test run. That might be a good idea, since it would give us early warning of any incompatible
change in a gem that Avro depends on. (And Gemfile.lock should not be committed to the repository.)

> Ruby client should use multi_json rather than being locked down to yajl
> -----------------------------------------------------------------------
>
>                 Key: AVRO-1063
>                 URL: https://issues.apache.org/jira/browse/AVRO-1063
>             Project: Avro
>          Issue Type: Improvement
>          Components: ruby
>            Reporter: Paul Dlug
>            Assignee: Duke
>            Priority: Minor
>             Fix For: 1.7.6
>
>         Attachments: AVRO-1063.diff, gemfile.patch
>
>
> The avro ruby client uses yajl for JSON serialization which is just one of many suitable
JSON implementations for ruby. The multi_json gem provides a wrapper for JSON serialization
selecting the fastest library available (Oj is now even faster than Yajl) and falling back
to a pure ruby implementation bundled with multi_json. Requiring yajl also precludes the ruby
gem from being used under jruby since it requires a C extension.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message