Return-Path: X-Original-To: apmail-avro-dev-archive@www.apache.org Delivered-To: apmail-avro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8236F10245 for ; Wed, 6 Nov 2013 00:16:19 +0000 (UTC) Received: (qmail 18205 invoked by uid 500); 6 Nov 2013 00:16:19 -0000 Delivered-To: apmail-avro-dev-archive@avro.apache.org Received: (qmail 18147 invoked by uid 500); 6 Nov 2013 00:16:19 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 18138 invoked by uid 99); 6 Nov 2013 00:16:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 00:16:19 +0000 Date: Wed, 6 Nov 2013 00:16:19 +0000 (UTC) From: "Hudson (JIRA)" To: dev@avro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AVRO-1384) avro-maven-plugin: Can't import idl files as classpath resources from the same set of sources MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AVRO-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814430#comment-13814430 ] Hudson commented on AVRO-1384: ------------------------------ SUCCESS: Integrated in AvroJava #400 (See [https://builds.apache.org/job/AvroJava/400/]) AVRO-1384. Java: Permit Maven to find imports within project. Contributed by Alexandre Normand. (cutting: rev 1539184) * /avro/trunk/CHANGES.txt * /avro/trunk/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java * /avro/trunk/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/IDLProtocolMojo.java * /avro/trunk/lang/java/maven-plugin/src/test/avro/AvdlClasspathImport.avdl * /avro/trunk/lang/java/maven-plugin/src/test/java/org/apache/avro/mojo/TestIDLProtocolMojo.java * /avro/trunk/lang/java/maven-plugin/src/test/resources/unit/idl/pom.xml > avro-maven-plugin: Can't import idl files as classpath resources from the same set of sources > ---------------------------------------------------------------------------------------------- > > Key: AVRO-1384 > URL: https://issues.apache.org/jira/browse/AVRO-1384 > Project: Avro > Issue Type: Improvement > Components: java > Affects Versions: 1.7.5 > Reporter: Alexandre Normand > Assignee: Alexandre Normand > Fix For: 1.7.6 > > Attachments: AVRO-1384-rev1.patch, AVRO-1384.patch, AVRO-1384.patch > > > We have a use case for importing idl files as classpath resources (it makes possible to re-use idls in downstream artifacts if all imports use classpath resources as opposed to a file-based reference). To enable this, the imports in the same artifacts should be able to use classpath resources for other avro files in the same source structure. > The proposed approach is to just add the source directory of avro files to the classpath. The avro resources would then follow the directory structure. This means that if someone configures the avro-maven-plugin with a source directory like this: > {code} > ${project.basedir}/src/main/resources > {code} > And the idl files live under {{project.basedir/src/main/resources/avro}}, the imports could be referencing other avro files like this: > {code} > import idl "avro/otherSchema.avdl"; > {code} > Things open for discussion: > * Any documentation required to make this clear to end-users? > * Should I add the resources directories to the classpath as well? -- This message was sent by Atlassian JIRA (v6.1#6144)