avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1388) Avro container files should allow fsync-ing files to disk
Date Wed, 06 Nov 2013 21:01:17 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815283#comment-13815283
] 

Doug Cutting commented on AVRO-1388:
------------------------------------

This looks good.  A few comments:
 - SyncableFileOutputStream needs some class-level javadoc
 - does @inheritDoc really work on constructors?
 - no need to worry about an HDFS implementation yet
 - we should add a test that check that sync() is called

The test might subclass ByteArrayOutputStream, implementing a Syncable that counts the number
of times sync() has been called.

> Avro container files should allow fsync-ing files to disk
> ---------------------------------------------------------
>
>                 Key: AVRO-1388
>                 URL: https://issues.apache.org/jira/browse/AVRO-1388
>             Project: Avro
>          Issue Type: Bug
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>         Attachments: AVRO-1388.patch
>
>
> Another feature we require in Avro data files in addition to AVRO-1387 is that we be
able to fsync the files to disk. Currently we cannot do this, but this can be achieved without
API changes. If there are no objections,  I will submit a patch



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message