Return-Path: X-Original-To: apmail-avro-dev-archive@www.apache.org Delivered-To: apmail-avro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93BA410178 for ; Fri, 11 Oct 2013 02:52:52 +0000 (UTC) Received: (qmail 51379 invoked by uid 500); 11 Oct 2013 02:52:48 -0000 Delivered-To: apmail-avro-dev-archive@avro.apache.org Received: (qmail 50947 invoked by uid 500); 11 Oct 2013 02:52:46 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 50850 invoked by uid 99); 11 Oct 2013 02:52:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Oct 2013 02:52:42 +0000 Date: Fri, 11 Oct 2013 02:52:42 +0000 (UTC) From: "graham sanderson (JIRA)" To: dev@avro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AVRO-1385) Enum reader/writer resolution doesn't report errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AVRO-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792287#comment-13792287 ] graham sanderson commented on AVRO-1385: ---------------------------------------- Doug - we wrote responses at the same time, but - I was wondering about other cases too, but just read the spec, because enum is a case I particularly care about (though haven't had to remove yet). I agree with you, but to be specific in this situation; I think that if at least a single possible datum exists written in the writer's schema that can be read by the reader's schema, then the failure should only be at runtime. Of course there may be some cases where for one reason or another you might choose to make further restriction for implementation reasons. > Enum reader/writer resolution doesn't report errors > --------------------------------------------------- > > Key: AVRO-1385 > URL: https://issues.apache.org/jira/browse/AVRO-1385 > Project: Avro > Issue Type: Bug > Components: java > Affects Versions: 1.7.5 > Reporter: Christophe Taton > Attachments: AVRO-1385.base=a56e7f13c4fa976b7926649b058665f42850a349.20131010-182234.patch > > > According to the specification, when a reader enum does not contain all symbols from the writer enum, an error should be signaled. > ResolvingGrammarGenerator fails to report such errors. > In particular, mkEnumAdjust() silently maps unknown symbols of the writers with symbols named "No match for [writer symbol]". > https://github.com/apache/avro/blob/trunk/lang/java/avro/src/main/java/org/apache/avro/io/parsing/ResolvingGrammarGenerator.java#L409 > Shouldn't this instead create an ErrorAction? -- This message was sent by Atlassian JIRA (v6.1#6144)