avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christophe Taton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1385) Enum reader/writer resolution doesn't report errors
Date Fri, 11 Oct 2013 01:30:44 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792222#comment-13792222
] 

Christophe Taton commented on AVRO-1385:
----------------------------------------

I am not sure whether this approach works fine. Reading through the unit-tests, it looks like
decoding an enum { A, B, C } as an enum { B, C } is supposed to not trigger any error at schema
resolution time. I believe that this contradicts the specification. Do I misunderstand something?

> Enum reader/writer resolution doesn't report errors
> ---------------------------------------------------
>
>                 Key: AVRO-1385
>                 URL: https://issues.apache.org/jira/browse/AVRO-1385
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.5
>            Reporter: Christophe Taton
>         Attachments: AVRO-1385.base=a56e7f13c4fa976b7926649b058665f42850a349.20131010-182234.patch
>
>
> According to the specification, when a reader enum does not contain all symbols from
the writer enum, an error should be signaled.
> ResolvingGrammarGenerator fails to report such errors.
> In particular, mkEnumAdjust() silently maps unknown symbols of the writers with symbols
named "No match for [writer symbol]".
> https://github.com/apache/avro/blob/trunk/lang/java/avro/src/main/java/org/apache/avro/io/parsing/ResolvingGrammarGenerator.java#L409
> Shouldn't this instead create an ErrorAction?



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message