avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Carey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1316) IDL code-generation generates too-long literals for very large schemas
Date Thu, 09 May 2013 16:39:17 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653062#comment-13653062
] 

Scott Carey commented on AVRO-1316:
-----------------------------------

We could make it so that 1.7.4 code can read classes generated with 1.7.5.

If the method that takes the split strings and merges them into one with the string buffer
before parsing is inside the generated class rather than Schema.Parser, the change would be
two-way compatible.  This is not quite as elegant however, and I think the requirement to
run code generated by 1.7.5 with 1.7.5 is reasonable.
                
> IDL code-generation generates too-long literals for very large schemas
> ----------------------------------------------------------------------
>
>                 Key: AVRO-1316
>                 URL: https://issues.apache.org/jira/browse/AVRO-1316
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Jeremy Kahn
>            Assignee: Jeremy Kahn
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.7.5
>
>         Attachments: AVRO-1316.patch, AVRO-1316.patch, AVRO-1316.patch, AVRO-1316.patch,
AVRO-1316.patch, AVRO-1316.patch, AVRO-1316.patch
>
>
> When I work from a very large IDL schema, the Java code generated includes a schema JSON
literal that exceeds the length of the maximum allowed literal string ([65535 characters|http://stackoverflow.com/questions/8323082/size-of-initialisation-string-in-java]).
 
> This creates weird Maven errors like: {{[ERROR] ...FooProtocol.java:[13,89] constant
string too long}}.
> It might seem a little crazy, but a 64-kilobyte JSON protocol isn't outrageous at all
for some of the more involved data structures, especially if we're including documentation
strings etc.
> I believe the fix should be a bit more sensitivity to the length of the JSON literal
(and a willingness to split it into more than one literal, joined by {{+}}), but I haven't
figured out where that change needs to go. Has anyone else encountered this problem?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message