avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uri Laserson (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AVRO-1304) Python Avro match_schemas called redundantly
Date Tue, 23 Apr 2013 20:15:17 GMT

     [ https://issues.apache.org/jira/browse/AVRO-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uri Laserson updated AVRO-1304:
-------------------------------

    Attachment: AVRO-1304.patch
    
> Python Avro match_schemas called redundantly
> --------------------------------------------
>
>                 Key: AVRO-1304
>                 URL: https://issues.apache.org/jira/browse/AVRO-1304
>             Project: Avro
>          Issue Type: Bug
>          Components: python
>    Affects Versions: 1.7.4
>            Reporter: Uri Laserson
>         Attachments: AVRO-1304.patch
>
>
> DatumReader.match_schemas(writers_schema, readers_schema) is called on every single read
from the DatumReader.  However, for almost every read, the schemas used are the object members
self.writers_schema and self.readers_schema.  match_schemas should be checked only once in
this case, and only when the object members are modified.  This takes up 20% of my parse time
upon profiling.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message