avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1268) Add java-class, java-key-class and java-element-class support for stringable types to SpecificData
Date Tue, 19 Mar 2013 15:57:16 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606434#comment-13606434
] 

Doug Cutting commented on AVRO-1268:
------------------------------------

Yes, a pre-computed tree would avoid this lookup.  When the DatumReader is constructed we'd
walk the schema, returning a parallel tree with resolved string classes as its leaves.  Then
we'd add a parameter to read() and pass this tree there.  Does that make sense?

We could also avoid these lookups if we added fields to Schema, which we probably don't want
to do.  Or we could try to optimize the lookups somehow.  Do you have any other ideas?
                
> Add java-class, java-key-class and java-element-class support for stringable types to
SpecificData
> --------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-1268
>                 URL: https://issues.apache.org/jira/browse/AVRO-1268
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.4
>            Reporter: Alexandre Normand
>            Assignee: Alexandre Normand
>            Priority: Minor
>             Fix For: 1.7.5
>
>         Attachments: AVRO-1268-needs-work.patch, AVRO-1268.patch, AVRO-1268.patch, AVRO-1268.sh,
GenericStringsPerf.patch
>
>
> Stringable types are java classes that can be serialized through strings (which require
a single string constructor and a valid toString() implementation). ReflectData currently
has support from stringable types but it would be desirable to get this feature with SpecificData.

> The work involves changes to the SpecificCompiler (depends on {{@java-class}} support
in AVRO-1267) to generate the specific sources with the proper java type as well as moving
the ReflectDatumReader and ReflectDatumWriter to read the java-class/java-key-class and java-element-class
properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message