Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Thu, 14 Feb 2013 20:41:13 +0000 (UTC)
From: "Doug Cutting (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: <JIRA.12632449.1360871026401.290261.1360874473122@arcas>
In-Reply-To: <JIRA.12632449.1360871026401@arcas>
References: <JIRA.12632449.1360871026401@arcas>
Subject: [jira] [Commented] (AVRO-1255) Python schema (message, protocol)
 to_json names argument should be optional
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AVRO-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13578653#comment-13578653 ] 

Doug Cutting commented on AVRO-1255:
------------------------------------

Looks reasonable to me.  We should also probably add some tests which don't pass a names parameter, no?
                
> Python schema (message, protocol) to_json names argument should be optional
> ---------------------------------------------------------------------------
>
>                 Key: AVRO-1255
>                 URL: https://issues.apache.org/jira/browse/AVRO-1255
>             Project: Avro
>          Issue Type: Improvement
>          Components: python
>    Affects Versions: 1.7.3
>            Reporter: Jeremy Kahn
>            Priority: Minor
>              Labels: patch
>         Attachments: avro-1255.patch
>
>
> The {{avro.protocol.Protocol}}, {{avro.protocol.Message}}, and various classes in {{avro.schema}} all support a {{to_json}} method which renders the data in Python generics (easily renderable to json).
> These methods all take a required {{names}} argument (of type {{avro.schema.Names}}) which stores state representing what types have already been rendered.
> For debugging -- and for other uses of the schema -- it is helpful if the {{names}} argument is optional.  When it is not provided, each method should construct an empty {{schema.Names}} object internally. {{to_json}} thus can be invoked without argument to get the relevant rendering of the current schema in isolation.
> Patch to be attached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira