avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AVRO-1242) AvroTrevniOutputFormat Metadata filter subString bug
Date Thu, 07 Feb 2013 00:08:13 GMT

     [ https://issues.apache.org/jira/browse/AVRO-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Doug Cutting updated AVRO-1242:

    Assignee: Ted Malaska

Thanks for finding this!

The patch looks mostly good.  Two minor nits:
 - The test uses tabs for indentation rather than 2-spaces per level.
 - The new method should be package-private, i.e., have no visibility annotation.  That way
it can be seen by the test (in the same package) but will not appear in the documentation
as a public API that we need to support.

> AvroTrevniOutputFormat Metadata filter subString bug
> ----------------------------------------------------
>                 Key: AVRO-1242
>                 URL: https://issues.apache.org/jira/browse/AVRO-1242
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.7.4
>            Reporter: Ted Malaska
>            Assignee: Ted Malaska
>             Fix For: 1.7.4
>         Attachments: AVRO-1242.patch
> In AvroTrevniOutputFormat there seems to be a cut and post error in the metadata filtering.
 The result is not "trevni.meta." metadatas will successfully get to the writer.
> if (e.getKey().startsWith(META_PREFIX))
>         meta.put(e.getKey().substring(AvroJob.TEXT_PREFIX.length()),
>                  e.getValue().getBytes(MetaData.UTF8));
> META_PREFIX = "trevni.meta."
> TEXT_PREFIX = "avro.meta.text."

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message