Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Mon, 17 Dec 2012 16:55:11 +0000 (UTC)
From: "Tom White (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: <JIRA.12617251.1353548329815.17388.1355763311392@arcas>
In-Reply-To: <JIRA.12617251.1353548329815@arcas>
References: <JIRA.12617251.1353548329815@arcas>
Subject: [jira] [Commented] (AVRO-1211) Add MR guide to documentation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AVRO-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534066#comment-13534066 ] 

Tom White commented on AVRO-1211:
---------------------------------

This looks good to me. A few comments:

* It would be useful to show the user Avro schema, and mention that it is compiled into a User class by Maven.
* "This will output the JSON representations of the Users generated" - an Avro data file is generated, not JSON, no?
* "You can check the contents of the generated Avro file using the Avro Python script" - you could use the Avro tools jar to achieve the same thing without relying on Python to be installed.
* It would be good if AvroWordCount implemented Tool too.
* Indentation should be 2 spaces in java files.
* "MapReduce" is the usual form (not "Map/Reduce")
                
> Add MR guide to documentation
> -----------------------------
>
>                 Key: AVRO-1211
>                 URL: https://issues.apache.org/jira/browse/AVRO-1211
>             Project: Avro
>          Issue Type: Improvement
>          Components: doc
>    Affects Versions: 1.7.2
>            Reporter: Skye Wanderman-Milne
>            Assignee: Skye Wanderman-Milne
>              Labels: docs
>             Fix For: 1.7.4
>
>         Attachments: AVRO-1211.1.patch, AVRO-1211.1.tar.gz, AVRO-1211.2.patch, AVRO-1211.2.tar.gz, mr-example.tar.gz
>
>
> Let's write more Avro documentation! This time we'll do a MapReduce example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira