avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AVRO-1175) BinaryData keeps a thread local reference after completing a compare, preventing compared arrays from being GC'd
Date Fri, 05 Oct 2012 22:08:02 GMT

     [ https://issues.apache.org/jira/browse/AVRO-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Doug Cutting updated AVRO-1175:
-------------------------------

    Attachment: AVRO-1175.patch

Here's a patch that I believe clears pointers to the buffer after each call to compare().
 After studying Scott's BufferAccessor and ByteSource stuff I think we can simply set the
pointers directly in the BinaryDecoder and that no others are retained.
                
> BinaryData keeps a thread local reference after completing a compare, preventing compared
arrays from being GC'd
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-1175
>                 URL: https://issues.apache.org/jira/browse/AVRO-1175
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.2
>            Reporter: Sandy Ryza
>            Assignee: Doug Cutting
>         Attachments: AVRO-1175.patch
>
>
> BinaryData holds on to BinaryDecoders as thread local variables (so it doesn't have to
make new ones for each compare?).  When a compare is completed, the BinaryDecoder still keeps
a reference to the ByteArrayByteSource, which stops its underlying byte array from being garbage
collected.
> This is causing an OutOfMemoryError in reducers when shuffling with MR2.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message