avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Percy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1156) Avro responder swallows thrown Errors
Date Tue, 11 Sep 2012 21:58:08 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453462#comment-13453462
] 

Mike Percy commented on AVRO-1156:
----------------------------------

Thanks for the feedback guys! Re. the zombie detection, makes sense... there appear to be
many benefits to doing it that way.

The issue I think I'm seeing is that an OOM error gets thrown while trying to service the
request, so we wrap it in an Exception and try to handle it, so the Responder tries to allocate
memory to serialize the error response and at that point another OOM error gets thrown by
the JVM and we lose the original error.

I think trying to handle certain Errors in general is a tough proposition... maybe most Errors
can be marshalled but OutOfMemoryError or VirtualMachineError should be special cased to just
propagate? Or if we really want to try, maybe we should just log the Errors before wrapping
them so at least we know if we are hitting a double-throw exception clobbering situation like
I am suspecting.

                
> Avro responder swallows thrown Errors
> -------------------------------------
>
>                 Key: AVRO-1156
>                 URL: https://issues.apache.org/jira/browse/AVRO-1156
>             Project: Avro
>          Issue Type: Bug
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>             Fix For: 1.7.2
>
>         Attachments: AVRO-1156-1.patch
>
>
> The Avro responder wraps caught Errors, such as OutOfMemoryErrors, in Exceptions and
rethrows them. That's problematic because an Error should be allowed to crash the JVM, since
it's often irrecoverable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message