avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1175) BinaryData keeps a thread local reference after completing a compare, preventing compared arrays from being GC'd
Date Fri, 28 Sep 2012 00:15:08 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465240#comment-13465240
] 

Todd Lipcon commented on AVRO-1175:
-----------------------------------

Seems that even if the keys themselves are small, they're in the middle of a big byte buffer.
So the decoder holding the reference to the byte array in a ThreadLocal is a no-no. Why not
add:
{code}
finally {
  decoders.b1.set(null, 0);
  decoders.b2.set(null, 0);
}
{code}

since there's otherwise no reason to hold onto the buffers in the threadlocal?
                
> BinaryData keeps a thread local reference after completing a compare, preventing compared
arrays from being GC'd
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-1175
>                 URL: https://issues.apache.org/jira/browse/AVRO-1175
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.2
>            Reporter: Sandy Ryza
>
> BinaryData holds on to BinaryDecoders as thread local variables (so it doesn't have to
make new ones for each compare?).  When a compare is completed, the BinaryDecoder still keeps
a reference to the ByteArrayByteSource, which stops its underlying byte array from being garbage
collected.
> This is causing an OutOfMemoryError in reducers when shuffling with MR2.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message