avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1151) Netty Avro server should expose the number of connections currently open.
Date Mon, 10 Sep 2012 12:59:07 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451936#comment-13451936
] 

Tom White commented on AVRO-1151:
---------------------------------

A few comments on the patch:

* Why close the channel and remove from allChannels in the channelDisconnected() method? Does
it not suffice to just have the channelClosed() method?
* The channel should also be removed from allChannels in exceptionCaught().
* There are some whitespace-only changes in the patch which should be removed.
                
> Netty Avro server should expose the number of connections currently open.
> -------------------------------------------------------------------------
>
>                 Key: AVRO-1151
>                 URL: https://issues.apache.org/jira/browse/AVRO-1151
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Hari Shreedharan
>            Priority: Minor
>         Attachments: AVRO-1151.patch
>
>
> It would be good to expose the number of currently open connections to the NettyServer
for metrics for applications using the server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message