avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1156) Avro responder swallows thrown Errors
Date Tue, 11 Sep 2012 22:14:07 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453477#comment-13453477
] 

Doug Cutting commented on AVRO-1156:
------------------------------------

If there's a memory leak through a static field then wrapping an exception for an OutOfMemoryError
might cause another OutOfMemoryError.  But if the OutOfMemoryError was caused by data only
pointed to by the stack of the request then it should be collectable by the time we catch
the exception and wrapping it shouldn't cause another OutOfMemoryError.  Are you sure that's
what's happening?

Try adding the extra logging there.  If that gets something logged that wouldn't be otherwise
then it's probably a good idea.  But if it just results in double-logging of the error (since
the container probably already logs errors) then it's probably not useful.
                
> Avro responder swallows thrown Errors
> -------------------------------------
>
>                 Key: AVRO-1156
>                 URL: https://issues.apache.org/jira/browse/AVRO-1156
>             Project: Avro
>          Issue Type: Bug
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>             Fix For: 1.7.2
>
>         Attachments: AVRO-1156-1.patch
>
>
> The Avro responder wraps caught Errors, such as OutOfMemoryErrors, in Exceptions and
rethrows them. That's problematic because an Error should be allowed to crash the JVM, since
it's often irrecoverable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message