avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Douglas Creager (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1115) avro-c: possible crash error in codec cleanup code
Date Mon, 18 Jun 2012 21:27:43 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396274#comment-13396274
] 

Douglas Creager commented on AVRO-1115:
---------------------------------------

I see {{(!type == 0)}} in the patch.  Should that be {{(type == NULL)}} instead?  I.e., fall
back on the null codec if the caller provided a NULL codec name?
                
> avro-c: possible crash error in codec cleanup code
> --------------------------------------------------
>
>                 Key: AVRO-1115
>                 URL: https://issues.apache.org/jira/browse/AVRO-1115
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.7.0
>            Reporter: Pugachev Maxim
>            Priority: Critical
>         Attachments: AVRO-1115.patch
>
>
> There is a possible crash error in codec cleanup code. Test-case is simple: you need
to call an "avro_file_writer_open" function with wrong file name (i.e. non-existent file).
Valgrind output:
> ==15259== Conditional jump or move depends on uninitialised value(s)
> ==15259==    at 0x40340A9: avro_codec_reset (in /home/mpugachev/work/avro-trunk/lang/c/src/libavro.so.22.0.0)
> ==15259==    by 0x4035FBC: avro_file_writer_open (in /home/mpugachev/work/avro-trunk/lang/c/src/libavro.so.22.0.0)
> ==15259==    by 0x80485B0: main (in /home/mpugachev/work/test/avro/example4)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message