Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Wed, 8 Feb 2012 19:38:59 +0000 (UTC)
From: "Scott Carey (Commented) (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: 
 <1587598041.16060.1328729939881.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <311301420.76083.1327483001015.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (AVRO-1007) Insufficient validation in generated
 specific record builder implementations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203889#comment-13203889 ] 

Scott Carey commented on AVRO-1007:
-----------------------------------

Slight clarification:

The schema above has worked for me in the past, but I am not sure if it has _always_ worked -- that was too strong of a statement.
                
> Insufficient validation in generated specific record builder implementations
> ----------------------------------------------------------------------------
>
>                 Key: AVRO-1007
>                 URL: https://issues.apache.org/jira/browse/AVRO-1007
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.6.1
>            Reporter: James Baldassari
>            Assignee: James Baldassari
>              Labels: java
>             Fix For: 1.6.2
>
>         Attachments: AVRO-1007-v2.patch, AVRO-1007-v3.patch, AVRO-1007-v4.patch, AVRO-1007.patch, AVRO-1007.patch, AVRO-1007.patch
>
>
> The are two main problems with the generated build() method in specific record builders:
> * For non-primitive types, if there is no default value and the user does not set the value, build() will execute successfully without throwing an exception
> ** Instead, an AvroRuntimeException should be thrown with an exception message indicating the name of the required field that was not set
> * For primitive types, if there is no default value and the user does not set the value, an AvroRuntimeException is thrown with the 'cause' set to a NullPointerException, which is not very helpful
> ** The NPE comes from attempting to set the primitive field to the result of defaultValue(), which is null

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira