avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raymie Stata (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1022) Error in validate name
Date Fri, 10 Feb 2012 14:32:59 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205475#comment-13205475
] 

Raymie Stata commented on AVRO-1022:
------------------------------------

I took a look at the non-Java implementations.  PHP validates names against the current spec
(i.e., ASCII letters only).  The rest don't validate names at all.  If we declared the current
spec correct, then "fixing" all of the implementations would consist of adding (or, for Java,
changing) 2-3 lines of simple, name-validation code, and some more code to turn validation
on and off.

If we went the other way (chance the spec), we'd have to answer a bunch of design questions
(decide what is a "letter," decide on normalization, figure out how to mangle names in various
languages, etc.), and then implement validation in each language (which, as Thiru points out,
would include adding an ICU dependency for C/C++, and maybe others (Ruby?  PHP?)), and then
implementing mangling where needed (a lot more than a few-line change).

As a practical matter, this wouldn't get done, and as the universe of Avro users becomes bigger
and bigger, fixing this broken corner of the Avro universe will become harder and harder.
                
> Error in validate name
> ----------------------
>
>                 Key: AVRO-1022
>                 URL: https://issues.apache.org/jira/browse/AVRO-1022
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Raymie Stata
>            Priority: Minor
>         Attachments: AVRO-1022.patch
>
>
> Fix schema.validateName to allow only ASCII letters, not Unicode letters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message