avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Baldassari (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations
Date Tue, 07 Feb 2012 04:58:59 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202078#comment-13202078
] 

James Baldassari commented on AVRO-1007:
----------------------------------------

These changes require regenerating/recompiling the specific record classes.  However, all
of these changes should be backwards-compatible with 1.6.  So if this goes out in 1.6.2 and
a user doesn't regenerate the specific records, everything should still work.
                
> Insufficient validation in generated specific record builder implementations
> ----------------------------------------------------------------------------
>
>                 Key: AVRO-1007
>                 URL: https://issues.apache.org/jira/browse/AVRO-1007
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.6.1
>            Reporter: James Baldassari
>            Assignee: James Baldassari
>              Labels: java
>             Fix For: 1.6.2
>
>         Attachments: AVRO-1007-v2.patch, AVRO-1007-v3.patch, AVRO-1007.patch
>
>
> The are two main problems with the generated build() method in specific record builders:
> * For non-primitive types, if there is no default value and the user does not set the
value, build() will execute successfully without throwing an exception
> ** Instead, an AvroRuntimeException should be thrown with an exception message indicating
the name of the required field that was not set
> * For primitive types, if there is no default value and the user does not set the value,
an AvroRuntimeException is thrown with the 'cause' set to a NullPointerException, which is
not very helpful
> ** The NPE comes from attempting to set the primitive field to the result of defaultValue(),
which is null

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message