avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1036) IDL processing fails with multi-level nested imports
Date Thu, 23 Feb 2012 22:23:49 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215125#comment-13215125
] 

Doug Cutting commented on AVRO-1036:
------------------------------------

Looks like we patched this in parallel!  You added some tests, which is great!

My patch is a little different.  When you include a file in a different directory then any
imports it contains should be relative to its directory, not the directory of the original
file, no?  So this.inputDir is not the right value for the new inputDir, but rather it should
come from the imported file.
                
> IDL processing fails with multi-level nested imports
> ----------------------------------------------------
>
>                 Key: AVRO-1036
>                 URL: https://issues.apache.org/jira/browse/AVRO-1036
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.6.2
>            Reporter: George Fletcher
>            Assignee: Doug Cutting
>             Fix For: 1.6.3
>
>         Attachments: AVRO-1036.patch, jira-1036.patch
>
>
> The change to support finding IDL related files on the classpath in addition to the maven-plugin
defined directory caused the context of the "sourceDirectory" to be lost when the InputStream
return by findFile() is used to create a new Idl instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message