avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Carey (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1024) Allow users to subclass JsonEncoder
Date Wed, 08 Feb 2012 23:16:59 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204099#comment-13204099

Scott Carey commented on AVRO-1024:

A different option from allowing modification by class extension is to consider opening JsonEncoder
(or its components) up enough to extend via composition instead of inheritance.  This may
expose less of the internals, or it may be difficult.

I don't like exposing Parser any more than it currently is.  Exposing Jackson is not as big
of a deal -- this is writing JSON after all.

> Allow users to subclass JsonEncoder
> -----------------------------------
>                 Key: AVRO-1024
>                 URL: https://issues.apache.org/jira/browse/AVRO-1024
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.5.4
>            Reporter: Elliott Clark
>         Attachments: AVRO-1024-1.patch
> Users who want to use a different representation of json from the JsonEncoder are forced
to re-implement all of it since JsonEncoder's internals are all private. For example I wanted
to make the json not contain type hints for unions.  That required only overriding one method
after this fix.
> To fix this making things protected will allow users to change just code that is needed.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message