avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thiruvalluvan M. G. (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1022) Error in validate name
Date Sat, 11 Feb 2012 02:54:59 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205995#comment-13205995
] 

Thiruvalluvan M. G. commented on AVRO-1022:
-------------------------------------------

bq. Maybe warnings aren't right. Maybe we should warn when validation is disabled and throw
exceptions when validation is enabled then enable folks to disable validation in tools.

Yes, I think we should, by default, conform to the spec. That is, it throw an exception stating
the names are not valid. Since we so far implemented it loosely, in order to maintain compatibility,
should allow non-ASCII names provided the user explicitly wants name validation relaxed. In
such situations we should also generate warnings.

This, while allowing the old schemas to be accepted, would encourage people to create conformant
schemas. Now, how does the user express his desire for lenient name validation? The user may
not have access to the source code that invokes the parser and so accepting a flag in the
parse function may not work. I suggest we use Java system property to pass this information
on.

Having said that, do we know if anyone uses non-ASCII names. Do we know if they are unwilling
or unable to fix their schemas? Are we solving a problem that doesn't really exist? Perhaps,
it is simpler if we just fix the code to conform to the spec and release it. We can do the
workaround described above if someone complains.
                
> Error in validate name
> ----------------------
>
>                 Key: AVRO-1022
>                 URL: https://issues.apache.org/jira/browse/AVRO-1022
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Raymie Stata
>            Priority: Minor
>         Attachments: AVRO-1022.patch, AVRO-1022.patch
>
>
> Fix schema.validateName to allow only ASCII letters, not Unicode letters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message