avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Cooper (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-960) String Const Correctness in Avro-C
Date Sun, 27 Nov 2011 04:10:40 GMT

    [ https://issues.apache.org/jira/browse/AVRO-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157651#comment-13157651
] 

Michael Cooper commented on AVRO-960:
-------------------------------------

Lucas, It appears your patch file is the wrong way around?
                
> String Const Correctness in Avro-C
> ----------------------------------
>
>                 Key: AVRO-960
>                 URL: https://issues.apache.org/jira/browse/AVRO-960
>             Project: Avro
>          Issue Type: Improvement
>          Components: c
>    Affects Versions: 1.6.1
>            Reporter: Lucas Martin-King
>            Priority: Minor
>              Labels: c, const
>         Attachments: avro_const_string.patch
>
>
> I notice that avro_value_set_string() takes in a char *, not a const char *, and some
of the the lower level functions it uses do take a const char *.
> I would presume that the library does not modify user input string data.
> Can we fix this by maintaining const char * all the way up to the user API?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message