avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thiruvalluvan M. G. (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AVRO-908) Add an option to build avrocpp as a static library
Date Fri, 07 Oct 2011 07:56:29 GMT

     [ https://issues.apache.org/jira/browse/AVRO-908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thiruvalluvan M. G. updated AVRO-908:
-------------------------------------

    Attachment: AVRO-908-rev-2.patch

Thanks Nebojsa for addressing this issue. 

The patch looks good. But instead of building either static or shared libraries, I think,
it is better to build both. The user can choose to use either of them based on his needs.
The new patch builds both the libraries. But unit tests are run against only the shared version.

I'll check in after receiving your feedback.
                
> Add an option to build avrocpp as a static library
> --------------------------------------------------
>
>                 Key: AVRO-908
>                 URL: https://issues.apache.org/jira/browse/AVRO-908
>             Project: Avro
>          Issue Type: New Feature
>          Components: c++
>    Affects Versions: 1.5.4
>            Reporter: Nebojsa Sabovic
>              Labels: cmake
>         Attachments: AVRO-908-rev-2.patch, AVRO-908.patch
>
>
> Use BUILD_SHARED_LIBS variable to control whether Avro-c++ library is built as a shared
library or as a static library. That way, people who want static library can use 'cmake -DBUILD_SHARED_LIBS=OFF'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message